Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev to main] v1.3.0 #55

Merged
merged 71 commits into from
Aug 20, 2024
Merged

[dev to main] v1.3.0 #55

merged 71 commits into from
Aug 20, 2024

Conversation

lsz05 and others added 30 commits July 1, 2024 17:23
Co-authored-by: Ryokan RI <ryou0634@gmail.com>
[Feature] Support data parallelism
[Feature] Support customizing `model_kwargs`
@lsz05 lsz05 marked this pull request as ready for review August 19, 2024 09:26
Copy link
Collaborator

@akiFQC akiFQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readmeだけ対応をお願いします

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2点更新お願いします。

  1. リーダーボードについての記述を強調していただく(現状、目立ってないので見落としそう)
  2. 複数GPUについてのnoteを追加いただく

@lsz05 lsz05 requested a review from akiFQC August 20, 2024 03:03
Copy link
Collaborator

@akiFQC akiFQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsz05 lsz05 merged commit d32922e into main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants