Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] DataParallelSentenceBertEmbedder in README #61

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

lsz05
Copy link
Collaborator

@lsz05 lsz05 commented Aug 29, 2024

関連する Issue / PR

N/A

PR をマージした後の挙動の変化

READMEにDataParallelSentenceBertEmbedderの表記が誤ったので修正します。

挙動の変更を達成するために行ったこと

READMEにDPSentenceBertEmbedderDataParallelSentenceBertEmbedderに修正

動作確認

  • テストが通ることを確認した
  • マージ先がdevブランチであることを確認した

@lsz05 lsz05 marked this pull request as ready for review August 29, 2024 16:06
@lsz05 lsz05 requested a review from akiFQC August 29, 2024 16:06
Copy link
Collaborator

@akiFQC akiFQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsz05 lsz05 merged commit f4b272e into dev Aug 30, 2024
3 checks passed
@lsz05 lsz05 mentioned this pull request Aug 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants