Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcp #21

Merged
merged 6 commits into from
May 7, 2019
Merged

Gcp #21

merged 6 commits into from
May 7, 2019

Conversation

sbneto
Copy link
Owner

@sbneto sbneto commented May 3, 2019

No description provided.

@sbneto sbneto requested a review from alanjds May 6, 2019 14:39
Copy link
Collaborator

@alanjds alanjds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Consider renaming StorageCls to storage_class, StorageClass or even StorageKlass
  • Lets not block this now, but before next release is better to provide GCP and maybe S3 as extras of s3conf package.
  • Is GCStorage test coverage good enough?

s3conf/client.py Show resolved Hide resolved
s3conf/storages.py Show resolved Hide resolved
@sbneto
Copy link
Owner Author

sbneto commented May 7, 2019

As a matter of fact, I did not find a reasonable way to test the GCPStorage locally. People have discussed this on googleapis/google-cloud-python#4897 and StackOverflow Question. There seems to be a way for Java, but I could not find a simple solution for Python.

@sbneto sbneto merged commit 3029f90 into master May 7, 2019
@sbneto sbneto deleted the gcp branch May 7, 2019 18:59
@alanjds
Copy link
Collaborator

alanjds commented May 7, 2019

As a matter of fact, I did not find a reasonable way to test the GCPStorage locally. People have discussed this on googleapis/google-cloud-python#4897 and StackOverflow Question. There seems to be a way for Java, but I could not find a simple solution for Python.

I am using pytest-vcr and marking the tests that do external calls. Well, the 1st run will be an integration test, but the next ones will be mocked using the recorded cassetes.

See: https://pypi.org/project/pytest-vcr/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants