Fix tagmenu oob #636
Merged
Fix tagmenu oob #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently will only shift elements back into view if out of bounds on the left. Not necessary at the moment to support oob on other sides, or support resizing to fit. Maybe in the future when it's used more.
… of ::before pseudoelement when more control is needed more control = need to be able to move it in js. Still supports using ::before, so not all menus need updating and can stay simple, just the menus needing more control can start using an actual element for the arrow.
TagMenu uses an element for the arrow now so the stayInView action can control its position.
IRHM
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
stayInViewaction (supports shifting elements that fall off left back into view).stayInViewaction onTagMenu.norm.scss: Support using an actual element for.menuarrow.Fixes #612