Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*** Assertion failure in + [NSView _findFirstKeyViewInDirection:forKeyLoopGroupingView:] #8

Closed
becknaum opened this issue Apr 6, 2017 · 5 comments
Assignees

Comments

@becknaum
Copy link

becknaum commented Apr 6, 2017

This was also an issue in the INPopoverController project.

According to that thread, this error sometimes arises when trying to enable keyboard access within a popover. It crashes the app on OS X 10.11 and previous. The only fix is to remove the contentView override accessor in SFBPopoverWindow.m.

I confirmed this fix in my project locally and can open a pull request for it as well.

@sbooth sbooth self-assigned this Apr 8, 2017
@sbooth
Copy link
Owner

sbooth commented Apr 8, 2017

I verified PR #9 fixes this issue.

I'm less certain if there would be any unintended side effects of the change. I think I'd prefer a fix where contentView was renamed to popoverContentView and is called explicitly.

@sbooth
Copy link
Owner

sbooth commented Feb 10, 2018

Fixed in 40b683d

@sbooth sbooth closed this as completed Feb 10, 2018
@joubin
Copy link

joubin commented May 25, 2019

Has the pod been update to reflect this change? It looks like the pod is still 1.0.0 and I'm still having this issues.

Thanks for the support

@joubin
Copy link

joubin commented Dec 16, 2019

Hey, I was wondering if the pod will ever be updated to include this change.

@sbooth
Copy link
Owner

sbooth commented Dec 16, 2019

I updated the podspec to version 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants