Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing contentView accessor - fix for keyboard access crash #9

Closed
wants to merge 2 commits into from
Closed

Removing contentView accessor - fix for keyboard access crash #9

wants to merge 2 commits into from

Conversation

becknaum
Copy link

@becknaum becknaum commented Apr 6, 2017

No description provided.

@sbooth
Copy link
Owner

sbooth commented Apr 8, 2017

I'm not certain if there are any unintended side effects of the change. I'd prefer a fix where contentView was renamed to popoverContentView and is called explicitly.

@becknaum
Copy link
Author

Do you mean making popoverContentView into an exposed property of SFBPopoverWindow to act as a wrapper around contentView?
From my understanding, the contentView setter must be overridden, and the getter cannot be. The contentView getter is not being explicitly called anywhere that I can find.

sbooth added a commit that referenced this pull request Feb 10, 2018
@sbooth
Copy link
Owner

sbooth commented Feb 10, 2018

I integrated these changes. Thanks!

@sbooth sbooth closed this Feb 10, 2018
jrhodes added a commit to InVisionApp/CCNStatusItem that referenced this pull request Mar 5, 2018
* Fix crash that occurs from overriding -contentView on a NSWindow instance.
* Changes derived from sbooth/SFBPopovers#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants