Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): Plugins status forwards & sbppchecker lib #1034

Draft
wants to merge 1 commit into
base: php81
Choose a base branch
from

Conversation

Rushaway
Copy link
Contributor

Description

  1. Fix library name conflict between sbpp_checker and sbpp_main (both were using "sourcebans++")
  2. Added forwards for each plugins who have natives to push informations about their available status

Motivation and Context

  1. We are verifying for LibraryExists with sourcebans++ for using sbpp checker natives, wich was always incorrect to due the same RegPluginLibrary as sbpp_main.
  2. I run a lot of plugins, and to make a correct implementation I need to check multiples things related:
  • LibraryExists on OnAllPluginsLoaded
  • OnLibraryAdded/OnLibraryRemoved in case of late load (or plugin reload) example of code

This kind of stuff, needed, can lead to massive boolean check on map change (See more details).
We can avoid this by just sending the informations via a forward.

How Has This Been Tested?

Tested with a test plugin implementing all new forwards:

  • Verified forward calls with PrintToServer
  • Tested plugin reload and pause scenarios
  • All forwards triggered as expected

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Rushaway
Copy link
Contributor Author

@Rushaway Rushaway marked this pull request as draft January 24, 2025 08:18
@rumblefrog
Copy link
Member

Is this ready for review, or still draft?

@Rushaway
Copy link
Contributor Author

Draft. I need to edit it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants