Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importlib.metadata on python3.8+ and importlib_metadata for 3.6,3.7 #111

Closed
wants to merge 2 commits into from
Closed

Use importlib.metadata on python3.8+ and importlib_metadata for 3.6,3.7 #111

wants to merge 2 commits into from

Conversation

miigotu
Copy link
Contributor

@miigotu miigotu commented Apr 9, 2021 •
edited
Loading

This removes the dependancy of setuptools for those of us using pyproject.toml and tools such as poetry and flit.

Signed-off-by: miigotu miigotu@gmail.com

@miigotu miigotu changed the title Use importlib.metadata on python3.8+ and importlib_metadata for every… Use importlib.metadata on python3.8+ and importlib_metadata for 3.6,3.7 Apr 9, 2021
miigotu referenced this pull request Apr 9, 2021
@sbraz
Replace pkg_resources with importlib.metadata, fixes #110
6aa8b14 
This allows us to drop the requirement for setuptools.
@miigotu
Use importlib.metadata on python3.8+ and importlib_metadata for every…
413dd27 
…thing up to and including python3.7

Signed-off-by: miigotu <miigotu@gmail.com>
@miigotu miigotu force-pushed the no-pkg-resources branch from 3d502df to 413dd27 Compare April 9, 2021 23:40
@miigotu
Copy link
Contributor Author

miigotu commented Apr 9, 2021

Since this was done by both of us (#110 and 6aa8b14) feel free to close this and use yours.

sbraz added a commit that referenced this pull request Apr 9, 2021
@sbraz
Replace pkg_resources with importlib.metadata, fixes #110, #111
6ff986e 
This allows us to drop the requirement for setuptools.
@miigotu
Fix build (lint)
7fd67aa 
Signed-off-by: miigotu <miigotu@gmail.com>
@sbraz
Copy link
Owner

sbraz commented Apr 9, 2021

Since this was done by both of us (#110 and 6aa8b14) feel free to close this and use yours.

I will be closing this as soon as I decide what to do with the __version__ thing. Sorry for making you do extra work, thanks for the help :)

@miigotu
Copy link
Contributor Author

miigotu commented Apr 9, 2021

Yeah its no problem, developers just jump in, and this was a smallish change =P Thanks for the project and taking care of this.

sbraz added a commit that referenced this pull request Apr 10, 2021
@sbraz @miigotu
Replace pkg_resources with importlib.metadata, fixes #110, #111
af4da52 
This allows us to drop the requirement for setuptools.

Also make __version__ an empty string when the package isn't installed,
for improved consistency.

Co-Authored-By: miigotu <miigotu@gmail.com>
@miigotu miigotu closed this Apr 10, 2021
sbraz added a commit that referenced this pull request Apr 10, 2021
@sbraz @miigotu
Replace pkg_resources with importlib.metadata, fixes #110, #111
8af1511 
This allows us to drop the requirement for setuptools.

Also make __version__ an empty string when the package isn't installed,
for improved consistency.

Co-Authored-By: miigotu <miigotu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miigotu @sbraz