Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 2.6 #27

Closed
wants to merge 2 commits into from
Closed

python 2.6 #27

wants to merge 2 commits into from

Conversation

nossal
Copy link

@nossal nossal commented Jul 19, 2016

Little changes to work with python 2.6. I hope you don't mind.

@sbraz
Copy link
Owner

sbraz commented Jul 20, 2016

How about just using sys.version_info[0]? It seems to work for all versions. Can you also add Python 2.6 to .travis.yml and rebase the commits into one for clarity?

@sbraz
Copy link
Owner

sbraz commented Jul 20, 2016

Looking at the code for xml.etree, I see that getiterator will soon issue a warning. Can you wrap the call into something like this?

if sys.version < (2, 7):
    …

@sbraz sbraz closed this in 8ee9c10 Jul 20, 2016
@sbraz
Copy link
Owner

sbraz commented Jul 20, 2016

The current master should work. I'll make a new release if you're happy with it.

@nossal
Copy link
Author

nossal commented Jul 20, 2016

Ok, thank you. I'll do a pull request with the suggested corrections.

@sbraz
Copy link
Owner

sbraz commented Jul 20, 2016

Did you see 8ee9c10? I don't think there is anything else to do, pymediainfo should now work with Python 2.6 :)

@nossal
Copy link
Author

nossal commented Jul 20, 2016

Wow, almost the same thing a did. Thank you!

@sbraz
Copy link
Owner

sbraz commented Jul 20, 2016

Yeah I wouldn't have noticed the extra whitespace at the end of the line without your PR, thanks and good luck with your old Python :D

@nossal
Copy link
Author

nossal commented Jul 20, 2016

Are you planning to make a new release soon?

@sbraz
Copy link
Owner

sbraz commented Jul 20, 2016

Yup, as I said, I'm just waiting for your approval of the changes.

On 20 Jul 2016 7:08 p.m., "Rodrigo Nossal" notifications@github.com wrote:

Are you planning to make a new release soon?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#27 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEnANI3XHhGSeSp9C7WRR5k9YUe5aHbbks5qXlYMgaJpZM4JQQf7
.

@nossal
Copy link
Author

nossal commented Jul 20, 2016

Works like a charm. Here is my ✔️

@sbraz
Copy link
Owner

sbraz commented Jul 21, 2016

And here is the new release:
https://github.com/sbraz/pymediainfo/releases/tag/v2.1.5 and https://pypi.python.org/pypi/pymediainfo

On 20 July 2016 at 19:33, Rodrigo Nossal notifications@github.com wrote:

Works like a charm. Here is my ✔️


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#27 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEnANDnWsvsLuxSjMewW-ksBJ6t1Ro0qks5qXlvagaJpZM4JQQf7
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants