This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Inferred #554
Merged
Inferred #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## sbromberger/simplegraphs #554 +/- ##
===========================================================
- Coverage 99.53% 99.43% -0.1%
===========================================================
Files 60 60
Lines 2992 2995 +3
===========================================================
Hits 2978 2978
- Misses 14 17 +3Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## sbromberger/simplegraphs #554 +/- ##
============================================================
+ Coverage 99.53% 99.53% +<.01%
============================================================
Files 60 60
Lines 2992 2995 +3
============================================================
+ Hits 2978 2981 +3
Misses 14 14Continue to review full report at Codecov.
|
sbromberger
added a commit
that referenced
this pull request
Mar 29, 2017
* benchmarks * add edgetype benchmark katz centrality is broken. * simplegraphs abstraction * Edge is no longer a Pair * pkgbenchmarks * f * remove data files from benchmarks * simplegraphs, take 2 * more changes * reshuffle * fix tests * more tests * abstractions * more tests * tests and fixes * trait fixes and tests - unrolling * persistence and floyd-warshall * make(di)graphs, through spanningtrees * moved cliques, testing through connectivity.jl * @jpfairbanks first round of review * another fix * all tests * new simpletraits * first cut at 0.6 compat * squash * update randgraphs.jl to use Channels over Tasks Fixes deprecation warnings introduced in: JuliaLang/julia#19841 Changes an API interface: -function Graph(nvg::Int, neg::Int, edgestream::Task) +function Graph(nvg::Int, neg::Int, edgestream::Channel) Iteration over Tasks is deprecated so now we iterate over the Channel. * got rid of tasks in randgraphs * graph -> g * Add tutorials to section on docs (#547) * Update README.md * Update README.md Made tutorials separate line and consistent with the other lines. * type -> mutable struct * more type -> mutable struct, plus OF detection for add_vertex! * foo{T}(x::T) -> foo(x::T) where T * test negative cycles * test coverage * manual cherry-pick of #551 * simplegraph/ -> simplegraphs, optimization for is_connected, some type simplifications * re-add b-f tests * Inferred (#554) * core * @inferred wherever possible * empty -> zero * test grid periodic=true * oops * redo graphmatrices tests * linalg test fix * loosen type restrictions in randgraphs functions * readall -> readstring, and comment rationalization in randgraphs * Fixes #555: graphmatrices convert incorrect on CA (#560) CombinatorialAdjacency(CombinatorialAdjacency(g)) was returning the backing storage. Fix includes tests. * fixes #564 * one more test * removed nv() and vertices() (#565) * simpleedge tests * test coverage * short circuit B-F negative cycles, plus tests * more test coverage * more test coverage * Docs (#567) * docs, plus some various fixes (see blocking_flow). * nodes -> vertices, node -> vertex, and more doc consistency * doc fixes * 1.0 -> 0.8 * docfix and benchmarks * doc fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
@inferredfor type stability checking wherever possible.