Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

closes #368 #575

Merged
merged 3 commits into from
Apr 7, 2017
Merged

closes #368 #575

merged 3 commits into from
Apr 7, 2017

Conversation

sbromberger
Copy link
Owner

is_connected and connected_components now throw method errors for directed graphs.

Verified

This commit was signed with the committer’s verified signature.
remcohaszing Remco Haszing
@codecov
Copy link

codecov bot commented Mar 29, 2017

Codecov Report

Merging #575 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #575   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          60     60           
  Lines        2988   2990    +2     
=====================================
+ Hits         2988   2990    +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8f557...0046898. Read the comment docs.

in `h` represents a strongly connected component in `g`, and the presence
of an edge between between vertices in `h` indicates that there is at least one
edge between the associated strongly connected components in `g`. The node
numbering in `h` corresponds to the ordering of the components output from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these docs deleted?

Copy link
Owner Author

@sbromberger sbromberger Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because those are docs for condensation, not attracting components. I think they were pasted in there by mistake, as they were word for word with condensation.

Verified

This commit was signed with the committer’s verified signature.
remcohaszing Remco Haszing

Verified

This commit was signed with the committer’s verified signature.
remcohaszing Remco Haszing
@sbromberger
Copy link
Owner Author

@jpfairbanks - mind giving this a review as well? Thanks.

@sbromberger
Copy link
Owner Author

I think this is the last PR holding up tagging of 0.8.

@sbromberger
Copy link
Owner Author

I plan on merging this tomorrow by end of day. It's a well-documented minor change that can be easily reversed if it causes problems. I'd like to tag 0.8.0 by next week.

@sbromberger sbromberger merged commit ff49e0c into master Apr 7, 2017
@sbromberger sbromberger deleted the sbromberger/fix368 branch April 7, 2017 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants