-
Notifications
You must be signed in to change notification settings - Fork 182
Conversation
1fe8c94
to
c7329a1
Compare
c7329a1
to
8af3780
Compare
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 60 60
Lines 2988 2990 +2
=====================================
+ Hits 2988 2990 +2 Continue to review full report at Codecov.
|
in `h` represents a strongly connected component in `g`, and the presence | ||
of an edge between between vertices in `h` indicates that there is at least one | ||
edge between the associated strongly connected components in `g`. The node | ||
numbering in `h` corresponds to the ordering of the components output from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these docs deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because those are docs for condensation
, not attracting components
. I think they were pasted in there by mistake, as they were word for word with condensation
.
@jpfairbanks - mind giving this a review as well? Thanks. |
I think this is the last PR holding up tagging of 0.8. |
I plan on merging this tomorrow by end of day. It's a well-documented minor change that can be easily reversed if it causes problems. I'd like to tag 0.8.0 by next week. |
is_connected
andconnected_components
now throw method errors for directed graphs.