Vertex Cover #949

SohamTamba · 2018-07-27T21:26:27Z

codecov · 2018-07-27T21:35:12Z

Codecov Report

Merging #949 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   99.85%   99.85%   +<.01%     
==========================================
  Files          80       83       +3     
  Lines        2691     2707      +16     
==========================================
+ Hits         2687     2703      +16     
  Misses          4        4

jpfairbanks

I would rather these be

vertex_cover(g::AbstractGraph, alg::RandomCover)
vertex_cover(g::AbstractGraph, alg::DegreeCover)
vertex_cover(g::AbstractGraph, alg::ParallelCover)

or

vertex_cover_random(g::AbstractGraph)
vertex_cover_degree(g::AbstractGraph)
vertex_cover_parallel(g::AbstractGraph)

so that the methods sort together in tab complete.

@sbromberger which bikeshed color do you prefer? I am in favor of more alg types. We could also make it kwargs.

sbromberger · 2018-07-27T22:49:35Z

which bikeshed color do you prefer?

Blue.

I think that consistency dictates we use either a passed struct to designate the algorithm (the way we do with loadgraph), or use a symbol (the way we do w/ adjacency_matrix). Making this a kwarg is preferable if there's an obvious default.

SohamTamba · 2018-07-30T08:35:32Z

@sbromberger can you take a look at this?

sbromberger · 2018-07-30T14:43:47Z

This looks good to me, but I'd like @jpfairbanks to take a look as well.

IssamT · 2018-07-30T14:50:07Z

Can we have some naming convention that helps recognizing heuristics from exact algorithms?

SohamTamba · 2018-07-31T14:52:31Z

@somil55
mapreduce seems to have the same run time as the sequential code.
Should I use @distributed instead?

dsrivastavv · 2018-07-31T18:40:02Z

@SohamTamba Try benchmarking it using @distributed [reducer] for loop.

SohamTamba · 2018-08-01T15:13:45Z

Efficiency is being discussed in #960

sbromberger · 2018-09-07T22:44:42Z

@SohamTamba this needs a conflict resolution. Also, what's the status? Are we ready for review? (cc @somil55 )

SohamTamba · 2018-09-08T08:37:13Z

@sbromberger It's ready but can we merge #960 first?

Changes will have to be made to this PR based on how #960 ends up.

…r#984) * Fix kruskal_mst for working with abstract graphs * Remove abstract edge type in kruskal * Fix edgetype

We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good.

…bromberger#1001)

* attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload

* Add simple_cycles_limited_length. * Revisions after review comments. Merging because it looks like codecov is hung up.

Fix zenodo error

* OneTo * fixes reverse (sbromberger#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (sbromberger#995) * SimpleGraph(SimpleGraph) plus tests. (sbromberger#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (sbromberger#1001) * fixes edgeiter equality (sbromberger#1002) * 32-bit compatibility (sbromberger#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (sbromberger#987) * misc doc fixes (sbromberger#1003) * Fix sbromberger#999 (sbromberger#1004) * Parallel BFS Generate Reduce

SohamTamba · 2018-09-09T20:51:36Z

@somil55 can you take a look?

sbromberger · 2018-09-14T23:38:12Z

@somil55 @jpfairbanks @SohamTamba - can we make a decision on this PR please? What needs to happen here? Thank you.

SohamTamba · 2018-09-15T05:13:01Z

@sbromberger I think its ready.

I changed the interface to use structs as requested.

sbromberger · 2018-09-17T22:19:01Z

Congrats, @SohamTamba - and thanks for a great GSOC!!!

SohamTamba · 2018-09-18T11:05:38Z

@sbromberger
Thanks alot :)

It was a great experience working with you'll

matbesancon · 2018-09-19T14:06:44Z

congrats @SohamTamba :)

* Fix kruskal_mst function for working with abstract graphs (#984) * Fix kruskal_mst for working with abstract graphs * Remove abstract edge type in kruskal * Fix edgetype * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Karger Min Cut (#988) * Fix misspelling. (#1005) * Fixed some bugs in simplecycles_hawick_james (#1007) * Add function to find short cycles (#1006) * Add simple_cycles_limited_length. * Revisions after review comments. Merging because it looks like codecov is hung up. * Update .zenodo.json Fix zenodo error * Parallel BFS with static and dynamic load balancing (#943) * OneTo * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Parallel BFS Generate Reduce * VertexCover

* inflate * Vertex Cover (#949) * Fix kruskal_mst function for working with abstract graphs (#984) * Fix kruskal_mst for working with abstract graphs * Remove abstract edge type in kruskal * Fix edgetype * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Karger Min Cut (#988) * Fix misspelling. (#1005) * Fixed some bugs in simplecycles_hawick_james (#1007) * Add function to find short cycles (#1006) * Add simple_cycles_limited_length. * Revisions after review comments. Merging because it looks like codecov is hung up. * Update .zenodo.json Fix zenodo error * Parallel BFS with static and dynamic load balancing (#943) * OneTo * fixes reverse (#994) We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good. * Lots more doctests (#995) * SimpleGraph(SimpleGraph) plus tests. (#998) * added documentation for SimpleGraph and SimpleDiGraph constructors (#1001) * fixes edgeiter equality (#1002) * 32-bit compatibility (#999) * attempt 32-bit compatibility * don't allow downsampling to Int32: introduces accuracy bugs * add 0.7 and nightly tests * allow integers in betweenness centrality * attempt to fix parallel 32-bit * work around splitrange issue * Revert "work around splitrange issue" This reverts commit 58cbcf8. * splitrange overload * MultiThreaded Centrality Measures Implementations (#987) * misc doc fixes (#1003) * Fix #999 (#1004) * Parallel BFS Generate Reduce * VertexCover * More examples... (#1014) * More examples... * Update core.jl shortcut to Digraph creation * Update bipartition.jl * More doctests (#1016) * Xrefs/examples again * More examples! (#1018) * Centrality examples (#1019) * Biconnectivity examples (#1021) * Examples for some operators (#1022) * Fixes https://github.com/JuliaGraphs/MetaGraphs.jl/issues/55 (#1023) * Fixes https://github.com/JuliaGraphs/MetaGraphs.jl/issues/55 (#1023)

jpfairbanks suggested changes Jul 27, 2018

View reviewed changes

SohamTamba force-pushed the VertexCover branch 5 times, most recently from 313f86c to 0aa787a Compare July 28, 2018 17:33

dsrivastavv approved these changes Jul 29, 2018

View reviewed changes

SohamTamba force-pushed the VertexCover branch 2 times, most recently from d5450df to aa6562f Compare July 31, 2018 13:27

sbromberger added this to the v1.1.0 milestone Jul 31, 2018

sbromberger added the GSOC 2018 label Aug 9, 2018

VPetukhov and others added 9 commits September 9, 2018 23:24

Fix kruskal_mst function for working with abstract graphs (sbromberge…

46bfbf9

…r#984) * Fix kruskal_mst for working with abstract graphs * Remove abstract edge type in kruskal * Fix edgetype

fixes reverse (sbromberger#994)

ea37d58

We will probably want to move this into SimpleGraphs at some point, but until then, I think this is good.

Lots more doctests (sbromberger#995)

7bc737b

SimpleGraph(SimpleGraph) plus tests. (sbromberger#998)

4355acc

added documentation for SimpleGraph and SimpleDiGraph constructors (s…

999f432

…bromberger#1001)

fixes edgeiter equality (sbromberger#1002)

15cd090

MultiThreaded Centrality Measures Implementations (sbromberger#987)

f181137

misc doc fixes (sbromberger#1003)

7e8bb4f

ChrisRackauckas and others added 7 commits September 9, 2018 23:24

Fix sbromberger#999 (sbromberger#1004)

67a6a2a

Karger Min Cut (sbromberger#988)

bf4cf25

Fix misspelling. (sbromberger#1005)

7330c55

Fixed some bugs in simplecycles_hawick_james (sbromberger#1007)

ea4c75c

Add function to find short cycles (sbromberger#1006)

105407c

* Add simple_cycles_limited_length. * Revisions after review comments. Merging because it looks like codecov is hung up.

Update .zenodo.json

5a543c1

Fix zenodo error

SohamTamba force-pushed the VertexCover branch from 08d8fdb to 3a54050 Compare September 9, 2018 20:29

SohamTamba force-pushed the VertexCover branch from b0c864a to 12e1db6 Compare September 10, 2018 08:18

SohamTamba and others added 4 commits September 10, 2018 19:18

VertexCover

12e1db6

Merge branch 'master' into VertexCover

5aad966

Merge branch 'master' into VertexCover

ef98bb0

Merge branch 'master' into VertexCover

5f668f4

jpfairbanks approved these changes Sep 17, 2018

View reviewed changes

sbromberger merged commit bfda546 into sbromberger:master Sep 17, 2018

SohamTamba mentioned this pull request Sep 24, 2018

Independent Set #1026

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vertex Cover #949

Vertex Cover #949

SohamTamba commented Jul 27, 2018

codecov bot commented Jul 27, 2018 •

edited

Loading

jpfairbanks left a comment •

edited

Loading

sbromberger commented Jul 27, 2018

SohamTamba commented Jul 30, 2018

sbromberger commented Jul 30, 2018

IssamT commented Jul 30, 2018

SohamTamba commented Jul 31, 2018

dsrivastavv commented Jul 31, 2018

SohamTamba commented Aug 1, 2018

sbromberger commented Sep 7, 2018

SohamTamba commented Sep 8, 2018

SohamTamba commented Sep 9, 2018

sbromberger commented Sep 14, 2018

SohamTamba commented Sep 15, 2018

sbromberger commented Sep 17, 2018

SohamTamba commented Sep 18, 2018

matbesancon commented Sep 19, 2018

Vertex Cover #949

Vertex Cover #949

Conversation

SohamTamba commented Jul 27, 2018

codecov bot commented Jul 27, 2018 • edited Loading

Codecov Report

jpfairbanks left a comment • edited Loading

Choose a reason for hiding this comment

sbromberger commented Jul 27, 2018

SohamTamba commented Jul 30, 2018

sbromberger commented Jul 30, 2018

IssamT commented Jul 30, 2018

SohamTamba commented Jul 31, 2018

dsrivastavv commented Jul 31, 2018

SohamTamba commented Aug 1, 2018

sbromberger commented Sep 7, 2018

SohamTamba commented Sep 8, 2018

SohamTamba commented Sep 9, 2018

sbromberger commented Sep 14, 2018

SohamTamba commented Sep 15, 2018

sbromberger commented Sep 17, 2018

SohamTamba commented Sep 18, 2018

matbesancon commented Sep 19, 2018

codecov bot commented Jul 27, 2018 •

edited

Loading

jpfairbanks left a comment •

edited

Loading