Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version numbers so building does not break #134

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

kleinicke
Copy link
Member

@kleinicke kleinicke commented Jan 6, 2025

Description

When building this error shows up:

Error TS5104: Option 'importsNotUsedAsValues' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
error TS5104: Option 'preserveValueImports' is redundant and cannot be specified with option 'verbatimModuleSyntax'.

✓ 2 modules transformed.
✓ built in 240ms
[vite-plugin-svelte] Error while preprocessing /Users/florian/Uni/SBS/IT/website/currentDev/src/routes/+layout.svelte - [svelte-preprocess] Encountered type error
file: /Users/florian/Uni/SBS/IT/website/currentDev/src/routes/+layout.svelte
error during build:
Error: Error while preprocessing /Users/florian/Uni/SBS/IT/website/currentDev/src/routes/+layout.svelte - [svelte-preprocess] Encountered type error
    at throwError (/Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte-preprocess@5.0.4_postcss@8.4.49_svelte@4.2.1_typescript@5.2.2/node_modules/svelte-preprocess/dist/modules/errors.js:5:11)
    at throwTypescriptError (/Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte-preprocess@5.0.4_postcss@8.4.49_svelte@4.2.1_typescript@5.2.2/node_modules/svelte-preprocess/dist/modules/errors.js:9:28)
    at transpileTs (/Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte-preprocess@5.0.4_postcss@8.4.49_svelte@4.2.1_typescript@5.2.2/node_modules/svelte-preprocess/dist/transformers/typescript.js:209:47)
    at simpleTranspiler (/Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte-preprocess@5.0.4_postcss@8.4.49_svelte@4.2.1_typescript@5.2.2/node_modules/svelte-preprocess/dist/transformers/typescript.js:300:60)
    at transformer (/Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte-preprocess@5.0.4_postcss@8.4.49_svelte@4.2.1_typescript@5.2.2/node_modules/svelte-preprocess/dist/transformers/typescript.js:345:11)
    at transform (/Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte-preprocess@5.0.4_postcss@8.4.49_svelte@4.2.1_typescript@5.2.2/node_modules/svelte-preprocess/dist/autoProcess.js:46:12)
    at async /Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte-preprocess@5.0.4_postcss@8.4.49_svelte@4.2.1_typescript@5.2.2/node_modules/svelte-preprocess/dist/autoProcess.js:117:29
    at async script (/Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte-preprocess@5.0.4_postcss@8.4.49_svelte@4.2.1_typescript@5.2.2/node_modules/svelte-preprocess/dist/autoProcess.js:147:33)
    at async process_single_tag (file:///Users/florian/Uni/SBS/IT/website/currentDev/node_modules/.pnpm/svelte@4.2.1/node_modules/svelte/src/compiler/preprocess/index.js:283:21)
    at async Promise.all (index 0)
 ELIFECYCLE  Command failed with exit code 1.

It can be fixed by making sure that we don't update single packages and have all of their versions fixed.

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for sbsev ready!

Name Link
🔨 Latest commit 9ec4e6d
🔍 Latest deploy log https://app.netlify.com/sites/sbsev/deploys/677c3b67ca45dd0008c38492
😎 Deploy Preview https://deploy-preview-134--sbsev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for sbs-austria ready!

Name Link
🔨 Latest commit 9ec4e6d
🔍 Latest deploy log https://app.netlify.com/sites/sbs-austria/deploys/677c3b67b9935400089a403d
😎 Deploy Preview https://deploy-preview-134--sbs-austria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dominikgeissler dominikgeissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@dominikgeissler dominikgeissler merged commit d5256b8 into main Jan 7, 2025
9 of 11 checks passed
@dominikgeissler dominikgeissler deleted the fix/ts-outdated-error branch January 7, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants