fix(multipart): always stream body #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multipart crate used by attohttpc has an issue when the form has only text fields, they are not computing the content length properly. I believe the problem is here where the
text_data
is appended with the proper value but thecontent_len
is not changed (so you only get the right body posted whenuse_len === false
. I could open a PR to their repo but I'm afraid it won't be merged since the project seems unmaintained, so I open this change here hoping it won't cause any issues.