Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Session type which can apply settings to requests created from it #52

Merged
merged 9 commits into from
Mar 7, 2020

Conversation

sbstp
Copy link
Owner

@sbstp sbstp commented Mar 1, 2020

No description provided.

@sbstp
Copy link
Owner Author

sbstp commented Mar 1, 2020

Review: @adamreichold

@sbstp
Copy link
Owner Author

sbstp commented Mar 1, 2020

Going to do a pass on the docs to make sure everything is still coherent.

@sbstp
Copy link
Owner Author

sbstp commented Mar 1, 2020

@adamreichold hey I was looking at the code and it seems like I missed something. Does rustls listen to the danger_accept_invalid_certs flag?

@adamreichold
Copy link
Contributor

hey I was looking at the code and it seems like I missed something. Does rustls listen to the danger_accept_invalid_certs flag?

It does not. It gets all of its configuration via the ClientConfig data type which is immutable because it is usually shared process-wide. Also note that those two flags do not exist when only the rustls backend is configured. As said in the original rustls MR, I see two options here: Implement API surface abstracting over native-tls and rustls covering the options we feel necessary to expose or align things by exposing TlsConnector directly so that library users can use that to configure things as they wish.

.travis.yml Outdated Show resolved Hide resolved
Simon Bernier St-Pierre added 2 commits March 7, 2020 09:39
@sbstp sbstp merged commit 43b3a4a into master Mar 7, 2020
@sbstp sbstp deleted the session branch March 7, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants