Do not try to resolve bracketed IP addresses #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL can contain IP addresses within brackets like "http://[::1]" which should not be resolve as a domain name but rather used as-is as an IP address. This change therefore makes use of Url::host instead of Url::host_str to determine the address to connect with whereas Url::host_str continues to be used for TLS authentication as this is always based on domain names.
|
@gh0st42 Could you give this a try? |
|
Issue seems to be resolved! Thanks |
|
Hello! Thanks for the report & the fix. I just published this in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL can contain IP addresses within brackets like "http://[::1]" which should
not be resolve as a domain name but rather used as-is as an IP address.
This change therefore makes use of Url::host instead of Url::host_str to determine
the address to connect with whereas Url::host_str continues to be used for TLS
authentication as this is always based on domain names.
Closes #53