New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy support #80

Merged

sbstp merged 15 commits into master from proxy

Oct 10, 2020

Owner

sbstp commented Oct 5, 2020 •

edited

Loading

Add support for configuring proxies
Detect proxies using curl like env variables (HTTP_PROXY, HTTPS_PROXY)
Normalize TLS interface between native-tls and rustls, both now support adding root certificates and disabling cert validation.

Addresses #77

Puffin McGoose added 3 commits

October 4, 2020 15:51


          Add ProxySettings struct

93580ed


          begin work to impl proxies

26d114b


          version that compiles

0687f05

sbstp changed the title ~~Proxy support~~ WIP: Proxy support


          allow proxy config

cc5f9ce

sbstp commented

View reviewed changes

src/error.rs Outdated Show resolved Hide resolved

Simon Bernier St-Pierre added 3 commits

October 5, 2020 21:02


          Begin work on automated testing

66c6ba9


          Partially functional test suite: need fixes for tls-rustls

36000a5


          Refactor tls support & clean up code using TLS

c9dda6b

sbstp commented

View reviewed changes

src/request/session.rs Show resolved Hide resolved

Simon Bernier St-Pierre added 3 commits

October 8, 2020 00:53


          Improve error handling for connect errors

30f83ac


          Fix clippy warnings & add tls funcs on session

a725ddc


          Add script to run clippy

6f78769

sbstp commented

View reviewed changes

src/request/mod.rs Outdated Show resolved Hide resolved

Simon Bernier St-Pierre added 3 commits

October 8, 2020 01:51


          Add support for root certificates & fix the custom verifier for rustls

03f44ef


          use matches!

d6b956a


          Fix clippy on beta

eaaa9f0

Owner Author

sbstp commented Oct 8, 2020

Hey @adamreichold, hope you are well. I've been working on adding support for proxies in attohttpc. I have something which is almost ready to be merged, just needs a few more tests. Was wondering if you could to take a look.

Owner Author

sbstp commented Oct 8, 2020

I remember that you had concerns about the TLS libraries being mutually exclusive. At the moment if both tls features are enabled, only native-tls is built.

sbstp commented

View reviewed changes

src/parsing/buffers.rs Outdated Show resolved Hide resolved

sbstp commented

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

sbstp commented

View reviewed changes

src/request/mod.rs Outdated Show resolved Hide resolved

sbstp commented

View reviewed changes

src/request/proxy.rs Show resolved Hide resolved


          Fix various things

05fffb7

sbstp mentioned this pull request

danger_accept_invalid_certs for tls-rusttls #69

Closed


          Add more tests for proxy, reduce amount of dev-dependencies

ed2f33d

sbstp changed the title ~~WIP: Proxy support~~ Proxy support

sbstp merged commit 25c07ab into master

sbstp deleted the proxy branch

October 10, 2020 21:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet