Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting the timestamp for jars, sort entries by name #279

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Nov 13, 2019

To allow making builds more reproducible/deterministic.

The changes in this PR are safe because the behavior doesn't change until the calling code switches to the new functions.

(This is a rebase of #58, but it appears github doesn't let you reopen PR's against deleted branches, and also doesn't let you retarget closed PR's...)

.. and sorting entries by name. This made building a minimal test
application 'repeatable' when building on the same machine but clearing
the target directory.

Related to sbt/zinc#333
@typesafe-tools
Copy link

A validation involving this pull request is in progress...

@typesafe-tools
Copy link

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt develop sbt/sbt@08c7fd1
zinc develop sbt/zinc@37665fc
io pull/279/head 605d908
librarymanagement develop sbt/librarymanagement@574be6f
util develop sbt/util@098796c

❌ The result is: FAILED
(restart)

@typesafe-tools
Copy link

A validation involving this pull request is in progress...

@typesafe-tools
Copy link

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt develop sbt/sbt@08c7fd1
zinc develop sbt/zinc@37665fc
io pull/279/head 605d908
librarymanagement develop sbt/librarymanagement@574be6f
util develop sbt/util@098796c

✅ The result is: SUCCESS
(restart)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants