Expose Milli.milli to let Zinc be more efficient #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can avoid the allocation of the `Path` => `File` conversion and also save extra calls to `readAttribute` when we are using `JavaMillis`.
- Avoid boxing of result by specializing
- Avoid allocations of Left/Right and lambda with an
imperative implementation
- Avoid allocations of list of excluded exceptions by caching
them at call sites.
eed3si9n
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can avoid the allocation of the
Path=>Fileconversionand also save extra calls to
readAttributewhen we are usingJavaMillis.