Remove millisecond-precision file timestamp using native code #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** Ref sbt/sbt#7463 Ref sbt/sbt#7455 On some Linux sbt 1.9.8 fail with "java.lang.UnsatisfiedLinkError: Error looking up function 'stat'". This is due to our workaround another stat related-issue. The general issue is that we currently call native call to retrieve the last modified time because JDK 8 use to have a bug JDK-8177809 that failed to get milliseconds. The bug was fixed in 2021 openjdk8u302. **Solution** We can drop the whole native code mechanism.
mergify bot
referenced
this pull request
in slick/slick
Feb 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.8` -> `1.9.9` | --- ### Release Notes <details> <summary>sbt/sbt (sbt/sbt)</summary> ### [`v1.9.9`](https://togithub.com/sbt/sbt/releases/tag/v1.9.9): 1.9.9 [Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.8...v1.9.9) #### Bug fixes - To fix `console` task on Scala 2.13.13, sbt 1.9.9 backports updates to JLine 3.24.1 and JAnsi 2.4.0 by [@​hvesalai](https://togithub.com/hvesalai) in [https://github.com/sbt/sbt/pull/7503](https://togithub.com/sbt/sbt/pull/7503) / [https://github.com/sbt/sbt/issues/7502](https://togithub.com/sbt/sbt/issues/7502) - To fix sbt 1.9.8's `UnsatisfiedLinkError` with `stat`, sbt 1.9.9 removes native code that was used to get the millisecond-precision timestamp that was broken ([JDK-8177809](https://bugs.openjdk.org/browse/JDK-8177809)) on JDK 8 prior to [OpenJDK 8u302](https://mail.openjdk.org/pipermail/jdk8u-dev/2021-July/014118.html) by [@​eed3si9n](https://togithub.com/eed3si9n) in [https://github.com/sbt/io/pull/367](https://togithub.com/sbt/io/pull/367) **Full Changelog**: sbt/sbt@v1.9.8...v1.9.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/slick/slick). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
cwienberg
referenced
this pull request
in cwienberg/spark-sorting-helpers
Apr 14, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.8` -> `1.9.9` | --- ### Release Notes <details> <summary>sbt/sbt (sbt/sbt)</summary> ### [`v1.9.9`](https://togithub.com/sbt/sbt/releases/tag/v1.9.9): 1.9.9 [Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.8...v1.9.9) #### Bug fixes - To fix `console` task on Scala 2.13.13, sbt 1.9.9 backports updates to JLine 3.24.1 and JAnsi 2.4.0 by [@​hvesalai](https://togithub.com/hvesalai) in [https://github.com/sbt/sbt/pull/7503](https://togithub.com/sbt/sbt/pull/7503) / [https://github.com/sbt/sbt/issues/7502](https://togithub.com/sbt/sbt/issues/7502) - To fix sbt 1.9.8's `UnsatisfiedLinkError` with `stat`, sbt 1.9.9 removes native code that was used to get the millisecond-precision timestamp that was broken ([JDK-8177809](https://bugs.openjdk.org/browse/JDK-8177809)) on JDK 8 prior to [OpenJDK 8u302](https://mail.openjdk.org/pipermail/jdk8u-dev/2021-July/014118.html) by [@​eed3si9n](https://togithub.com/eed3si9n) in [https://github.com/sbt/io/pull/367](https://togithub.com/sbt/io/pull/367) **Full Changelog**: sbt/sbt@v1.9.8...v1.9.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cwienberg/spark-sorting-helpers). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ref sbt/sbt#7463
Ref sbt/sbt#7455
On some Linux sbt 1.9.8 fail with "java.lang.UnsatisfiedLinkError: Error looking up function 'stat'". This is due to our workaround another stat related-issue. The general issue is that we currently call native call to retrieve the last modified time because JDK 8 use to have a bug JDK-8177809 that failed to get milliseconds.
The bug was fixed in 2021 openjdk8u302.
Solution
We can drop the whole native code mechanism.