Be friendly to SBT plugins that also use URLHandlerRegistry.setDefault #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing string interp
fix incorrect eviction warning message
add Java 9 test
Other plugins (for example: https://github.com/frugalmechanic/fm-sbt-s3-resolver) also make use of the URLHandlerRegistry.setDefault mechanism to register handlers for other protocols (e.g. "s3"). This change makes it so that SBT will only register the http/https protocols and will preserve any other protocol handlers that have already been registered.
|
The validator has checked the following projects against Scala 2.12,
✅ The result is: SUCCESS |
|
I've now tested this fix and it resolves the conflict with fm-sbt-s3-resolver. Here is what I did:
So from my standpoint everything looks good! |
This was referenced Nov 22, 2017
eed3si9n
approved these changes
Nov 24, 2017
|
I'm retargeting this to 1.0.x branch so we can include this in sbt 1.0.x. |
robhudson
added a commit
to mozilla/moztelemetry
that referenced
this pull request
Nov 27, 2017
After merging it was discovered that there was a bug in sbt [1] preventing `sbt publish` from working. This reverts the changes and updates until this bug is fixed and a new sbt release published. [1] sbt/librarymanagement#183
robhudson
added a commit
to mozilla/moztelemetry
that referenced
this pull request
Nov 27, 2017
After merging it was discovered that there was a bug in sbt [1] preventing `sbt publish` from working. This reverts the changes and updates until this bug is fixed and a new sbt release published. [1] sbt/librarymanagement#183
fbertsch
pushed a commit
to mozilla/moztelemetry
that referenced
this pull request
Nov 27, 2017
After merging it was discovered that there was a bug in sbt [1] preventing `sbt publish` from working. This reverts the changes and updates until this bug is fixed and a new sbt release published. [1] sbt/librarymanagement#183
robhudson
added a commit
to mozilla/moztelemetry
that referenced
this pull request
Nov 30, 2017
This adds a Docker container to run locally for development and for testing, as well as updates various dependencies to latest versions, and moves to CircleCI for testing and publishing. This commit differs from the prior commits by using sbt 1.0.4 which fixes a problem with `sbt publish`. See: sbt/librarymanagement#183
robhudson
added a commit
to mozilla/moztelemetry
that referenced
this pull request
Nov 30, 2017
This adds a Docker container to run locally for development and for testing, as well as updates various dependencies to latest versions, and moves to CircleCI for testing and publishing. This commit differs from the prior commits by using sbt 1.0.4 which fixes a problem with `sbt publish`. See: sbt/librarymanagement#183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other plugins (for example: https://github.com/frugalmechanic/fm-sbt-s3-resolver)
also make use of the URLHandlerRegistry.setDefault mechanism to register handlers
for other protocols (e.g. "s3"). This change makes it so that SBT will only
register the http/https protocols and will preserve any other protocol handlers
that have already been registered.
NOTE: This has now been tested and fixes #175