Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand allowed maven repository id characters to match maven #380

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Expand allowed maven repository id characters to match maven #380

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3de165c
Expand allowed maven repository id characters to match maven
May 28, 2021
976ff44
Fix logic and added test
Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ivy/src/main/scala/sbt/internal/librarymanagement/MakePom.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ class MakePom(val log: Logger) {
s.toArray.map(_.asInstanceOf[DependencyResolver])

def toID(name: String) = checkID(name.filter(isValidIDCharacter).mkString, name)
def isValidIDCharacter(c: Char) = c.isLetterOrDigit
def isValidIDCharacter(c: Char) = """\/:"<>|?*""".contains(c)
peter-janssen marked this conversation as resolved.
Show resolved Hide resolved
private def checkID(id: String, name: String) =
if (id.isEmpty) sys.error("Could not convert '" + name + "' to an ID") else id
def mavenRepository(repo: MavenRepository): XNode =
Expand Down