Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scala 3 binary version #384

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Fix Scala 3 binary version #384

merged 1 commit into from
Jul 9, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Jul 8, 2021

Fixes sbt/sbt#6585

The binary version of 3.x.y-foo-bar should be 3 if x > 0 or y > 0.

Example:

  • for 3.0.1-bin-nonbootstrapped it should be 3
  • for 3.0.1-SNAPSHOT it should be 3

@smarter @prolativ

- for 3.0.1-bin-nonbootstrapped it should be 3
- for 3.0.1-SNAPSHOT it should be 3
@adpi2 adpi2 requested a review from eed3si9n July 8, 2021 11:19
@prolativ
Copy link

prolativ commented Jul 8, 2021

Not sure if we should care about versions with missing patch number like 3.1 or 3.2-bin-foo or not. In theory this shouldn't be a problem if we never decide to release such versions

@smarter
Copy link
Contributor

smarter commented Jul 8, 2021

Compiler version numbers should always have a patch field yes.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrectly calculated binary scala versions for scala 3
4 participants