This repository has been archived by the owner on Feb 28, 2021. It is now read-only.
Be more frugal with HTTP client thread pool #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConcurrentMap.getOrElseUpdate may run the thunk without eventually insering the computed value in the map, if multiple threads are calling it for a given key. This situation seems to happen in SBT setting evaluation, perhaps in multi-module builds. The upshot is that Netty creates 2 x $numcpus "New NIO Worker" threads that live until the JVM exits. This commit adds synchronization around the interaction with the cache to ensure a given cache key only creates a single HTTP client and thread pool. Future work could reuse a HTTP client for all of Bintray's usage. I haven't made that change because I can't find documentation of the threadsafety of dispatch.Http.
The idea is to avoid paying for these threads until one actually publishes something.
|
I'm not sure how much automated testing we have here, so this might need manual testing before merge. |
|
I have tried these changes on a simple project and it seems to help. Loading sbt with the sbt-bintray
Loading sbt with the sbt-bintray from this PR:
|
2m
approved these changes
Mar 27, 2018
eed3si9n
approved these changes
Mar 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in the commit comments.
Historical context:
Prior to #53, the HTTP client
was created and discarded on each operation (which wasn't leaky but
was presumably a drag on performance.) I notice that in that change,
a
closeoperation was added toBintrayRepobut it isn't actuallycalled.
Fixes #144