This repository has been archived by the owner on Apr 8, 2021. It is now read-only.
[0.10.0-RC1 + sbt 1.2.5+ regression] ignore cached resolution for the dedicated update report #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 7992dc9, a custom, non-cached-resolution-aware update task was used to generate the report that the tree is based on, effectively ignoring the cached resolution flag at the project level. Starting 7992dc9, this plugin, when run with sbt 0.13.8 or sbt 1.2.5+, relies on cached-resolution-backed reports for projects that have the engine enabled via `updateOptions`. Other 1.x releases are not directly impacted as sbt had a buggy implementation of the feature anyway, see sbt/sbt#3761. Cached resolution has the side effect of generating an ivy report with artificial module descriptors which makes it hard to reconstruct the tree without inlining sbt internals (see below), so this effectively ignores it *for the purpose of the tree generation*, even if the project enabled it for the regular report. ModuleId( org.scala-sbt.temp, temp-resolve-e2a956132f02c038285b41b374c02f5838076f37, 1.0 ) https://github.com/sbt/librarymanagement/blob/984de6f/ivy/src/main/scala/sbt/internal/librarymanagement/ivyint/CachedResolutionResolveEngine.scala#L137
bjaglin
force-pushed
the
cachedresolution
branch
from
c02ca52
to
31d9355
Compare
bjaglin
changed the title
bjaglin
changed the title
jrudolph
approved these changes
Sep 7, 2019
I think it's perfectly fine :) No need to support |
|
Thanks again, @bjaglin! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes empty
dependencyTreeon 0.10.0-RC1 with sbt 0.13.18, 1.2.5, 1.2.6, 1.2.7, 1.2.8 for projects withupdateOptions.withCachedResolution(true).sbt 1.3.0-RC4 does not exhibit that specific issue by default (although it has another one almost as big, the tree is flat because the caller info is missing from the report) as cached resolution is ignored when using coursier as librarymanagement, however the behavior is the same as 1.2.5+ when disabling coursier via
useCoursier := false.See commit message for more details.
That initial regression fix is clearly a hack, but I am not sure supporting cached resolution would be more robust given how opaque/internal artificial module descriptor names are. Also, from what I understand, cached resolution is on its way out with the usage of coursier by default in sbt 1.3, so this might not be the best time investment.
Related to #176.