Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Meson build tool #147

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Add support for Meson build tool #147

merged 1 commit into from
Jun 2, 2023

Conversation

mihnea-s
Copy link
Contributor

Meson (https://mesonbuild.com/) is a popular building system similar to CMake, used by projects such as GLib (https://gitlab.gnome.org/GNOME/glib/).

@pomadchin pomadchin self-requested a review May 25, 2023 12:16
@pomadchin
Copy link
Member

Hello @mihnea-s, thanks for making a PR! Unfortunately it looks like meson is not installed on a CI VMs. Could you fix the CI as well?

@mihnea-s
Copy link
Contributor Author

I'm not entirely sure where I should do that, would something like this work in .github/workflows/ci.yml?

index e8d74d7..7a2e2e0 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -26,6 +26,10 @@ jobs:
         with:
           distribution: ${{ matrix.distribution }}
           java-version: ${{ matrix.java }}
+      - uses: actions/setup-python@v1
+        with:
+          python-version: '3.x'
+      - run: pip install meson ninja
 
       - name: Check formatting
         run: sbt scalafmtCheckAll

@pomadchin
Copy link
Member

@mihnea-s yea, just try it out. I also think there is a solid chance that python is preinstalled, so it could be just pip install 🤷

@mihnea-s mihnea-s force-pushed the main branch 2 times, most recently from ea9a0a0 to 35aad3b Compare May 26, 2023 20:36
@mihnea-s
Copy link
Contributor Author

Thanks! That works

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks and congratulations with the first contribution! 🎉

@pomadchin pomadchin merged commit ef56c2d into sbt:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants