Redefine definedTests in terms of the task itself
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with other plugins which may redefine the task
eed3si9n
reviewed
Oct 17, 2024
src/plugin/src/main/scala/com/github/sbt/junit/jupiter/sbt/JupiterPlugin.scala
Outdated
Show resolved
Hide resolved
… definition Co-authored-by: Eugene Yokota <eed3si9n@gmail.com>
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Nov 14, 2024
…o 5.11.3 ### What changes were proposed in this pull request? This pr aims to upgrade `jupiter-interface` from 0.13.0 to 0.13.1 and Junit5 to the latest version（Platform 1.11.3 + Jupiter 5.11.3）. ### Why are the changes needed? The new version of `jupiter-interface` brings two fixes: - sbt/sbt-jupiter-interface#122 - sbt/sbt-jupiter-interface#116 Simultaneously upgraded Junit dependencies to Platform 1.11.3 + Jupiter 5.11.3: - sbt/sbt-jupiter-interface#119 The full release notes of `jupiter-interface` as follows: - https://github.com/sbt/sbt-jupiter-interface/releases/tag/v0.13.1 and the full release notes between Junit 5.11.0 to 5.11.3 as follows: - https://junit.org/junit5/docs/5.11.3/release-notes/#release-notes-5.11.3 - https://junit.org/junit5/docs/5.11.3/release-notes/#release-notes-5.11.2 - https://junit.org/junit5/docs/5.11.3/release-notes/#release-notes-5.11.1 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #48834 from LuciferYang/junit5-5.11.3. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefine
definedTestsin terms of the task itself to work correctly with other plugins which may redefine the task, instead of hardcoding it toDefaults.detectTests.