-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Suite support #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
force-pushed
the
wip/suite
branch
2 times, most recently
from
July 28, 2024 05:12
e41ef28
to
9c200c7
Compare
… source - e.g. the platform (skipped by path.stream().skip(1) - e.g. for JUnit 5 suites the engine used to start the test in the test suite
I understand if the original intention of the fix for The JUnit 3 // src/test/MathTest.scala
// This is a definition of a JUnit 3 test case. Many of these test cases will be "dynamically" collected into a JUnit 3 `TestSuite` and run.
class MathTest(op1: Int, op2: Int, res: Int) extends TestCase(s"$op1 + $op2 = $res") {
final override def runTest(): Unit = {
assertEquals(res, op1 + op2)
}
} // src/test/MathSuite.scala
class MathSuite extends TestCase
object MathSuite {
// This is essentially a Scala 2.12+ hack, where methods on the companion object produce static forwarders on the class.
// This is the Scala equivalent of the JUnit 3 convention public static Test suite() { ... }
def suite(): Test = {
val s = new TestSuite("MathSuite")
s.addTest(new MathTest(1, 2, 3))
s.addTest(new MathTest(2, 3, 4))
s
}
} |
jodersky
added a commit
to jodersky/sbt-jupiter-interface
that referenced
this pull request
Nov 19, 2024
This amends changes from sbt#87, by removing the redundant ".skip(1)", and also reverts the changes done to the corresponding unit test.
jodersky
added a commit
to jodersky/sbt-jupiter-interface
that referenced
this pull request
Nov 19, 2024
This amends changes from sbt#87, by removing the redundant ".skip(1)", and also reverts the changes done to the corresponding unit test.
eed3si9n
pushed a commit
that referenced
this pull request
Nov 27, 2024
This amends changes from #87, by removing the redundant ".skip(1)", and also reverts the changes done to the corresponding unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
This cherry picks the Suite support from @Nezisi's Nezisi/sbt-jupiter-interface@bump-sbt-1_8...Nezisi:sbt-jupiter-interface:fix-junit5-suite-support branch.