This repository has been archived by the owner on Apr 25, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sbt/sbt#5045
Ref sbt/sbt#3559
Currently we set
-XX:+UseParallelGC
for JDK greater than 9. This isn't a great default because while the peak throughput is somewhat better than the default g1 collector, the worst case performance is really bad with UseParallelGC, especially when the heap size is large.Given the sudden diversification of JDK implementations, we should stay clear from
-XX
flags, and let the build users add them if they must.note
Since there are concerns that we are undoing #189, here's some adhoc local testing.
scala/scala
gcg1 is 1% slower.
ThoughtWorksInc/Dsl.scala
gcg1 is 1% faster.