This repository was archived by the owner on Apr 25, 2021. It is now read-only.
Don't pass MaxPermSize to Java 8+ #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...don't bother if won't use them due to them already being defined.
This change stops this annoying message being written to stderr (which can cause IntelliJ to freak): ``` Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0 ``` See also: https://bugs.openjdk.java.net/browse/JDK-6964458 sbt/sbt-native-packager#203 https://github.com/typesafehub/activator/issues/422
|
cc @jsuereth ✨ |
| (( $codecache < 512 )) || codecache=512 | ||
|
|
||
| local common_opts="-Xms${mem}m -Xmx${mem}m -XX:ReservedCodeCacheSize=${codecache}m" | ||
| if [[ "$java_version" < "1.8" ]]; then |
|
Looks great, thanks for the fixes! |
jsuereth
added a commit
that referenced
this pull request
Apr 29, 2014
Don't pass MaxPermSize to Java 8+
|
Thanks! |
|
Just got a notification that pointed to this... could I recommend rather than not configuring the size at all, that you configure it via MaxMetaspaceSize? See: https://github.com/typesafehub/activator/pull/506 If you don't configure it, then in Java 8, classloader leaks end up leaking system memory, so over time sbt will cause the system to run out of memory, causing swapping and potentially an eventual system crash (or the Linux OOM killer will start choosing random kittens to kill). Given that sbt's test and run tasks very often run in JVM, and that these very often have classloader leaks, this is something that sbt should take particular care to ensure doesn't happen. |
rtyley
added a commit
to rtyley/sbt-launcher-package
that referenced
this pull request
Oct 1, 2014
@jroper points out that class metadata has to go somewhere, and it's new name is 'Metaspace' - not 'PermGen': sbt#66 (comment) http://java.dzone.com/articles/java-8-permgen-metaspace
rtyley
added a commit
to rtyley/sbt-launcher-package
that referenced
this pull request
Oct 1, 2014
@jroper points out that class metadata has to go somewhere, and it's new name is 'Metaspace' - not 'PermGen': sbt#66 (comment) http://java.dzone.com/articles/java-8-permgen-metaspace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change stops this annoying message being written to stderr (which can cause IntelliJ to freak):
See also:
https://bugs.openjdk.java.net/browse/JDK-6964458
sbt/sbt-native-packager#203
https://github.com/typesafehub/activator/issues/422
Re-producing the warning message: