Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swtich to OpenJDK #1239

Closed
jiminhsieh opened this issue Jun 18, 2019 · 3 comments · Fixed by #1241
Closed

Swtich to OpenJDK #1239

jiminhsieh opened this issue Jun 18, 2019 · 3 comments · Fixed by #1241
Labels
project General project issues

Comments

@jiminhsieh
Copy link
Contributor

Expected behaviour

It's better to use OpenJDK at Travis CI.

Actual behaviour

We use Oracle JDK at Travis CI, and it causes a build failure.

Information

The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .

https://travis-ci.org/sbt/sbt-native-packager/jobs/545737004#L166
@muuki88 muuki88 added the project General project issues label Jun 19, 2019
@muuki88
Copy link
Contributor

muuki88 commented Jun 19, 2019

Thanks for your issue 😄 Would you like to open a pull request and change this 😎

@jiminhsieh
Copy link
Contributor Author

Sure. I'm glad I can help. :)

@muuki88
Copy link
Contributor

muuki88 commented Jun 19, 2019

Awesome 😍 Looking forward to your pull request

muuki88 added a commit that referenced this issue Jun 21, 2019
@muuki88
FIx #1239 Use jdk8 instead of 10 by defautl
0a9eed2
@jiminhsieh jiminhsieh mentioned this issue Jun 21, 2019
Merged
muuki88 added a commit that referenced this issue Jun 21, 2019
@muuki88
Fix #1239 use oraclejdk for OSX and jdk-packager builds
4c36270
muuki88 added a commit that referenced this issue Jun 21, 2019
@muuki88
Fix #1239 use openjdk11 for OSX
bcfa94c
muuki88 added a commit that referenced this issue Jun 21, 2019
@muuki88
Fix #1239 use oraclejdk10 which still has javafx
ef5d71a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project General project issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use OpenJDK intead of Oracle JDK jiminhsieh/sbt-native-packager
2 participants
@muuki88 @jiminhsieh