Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include subprojects in parent aggregator #19

Closed
jsuereth opened this issue Aug 20, 2013 · 4 comments
Closed

include subprojects in parent aggregator #19

jsuereth opened this issue Aug 20, 2013 · 4 comments

Comments

@jsuereth
Copy link
Member

Also, subprojects in parent play.Project aggregator that are only included in .dependsOn(...) do not have their jar generated (i.e. in order for a subproject jar to be generated it must be specified in .aggregate(...), not desired behavior at all)

See playframework/playframework#1499

cc> @godenji
@jsuereth
Copy link
Member Author

@huntc Here's the duplicate issue to track the issue on my end.

@huntc
Copy link
Contributor

huntc commented Aug 20, 2013

Thanks!

@jsuereth
Copy link
Member Author

Ok, think I have a fix, going to push shortly.

In the meantime, you can set exportJars := true in your child projects and the parent will get the jars in play 2.2.

jsuereth added a commit that referenced this issue Aug 21, 2013
@jsuereth
Adding test for bug #19
464a9f1
jsuereth added a commit that referenced this issue Aug 21, 2013
@jsuereth
Ensure that dependent projects (and our own) jars are created when
2486793 
making a JavaApp distribution.  We use the dependency-classpath in Runtime
to determine classpath ordering, but we pull jars directly from the
packagedArtifacts keys of dependent projects.  Uses a bit of
advanced sbt hackery.

Fixes #19

However, this introduces an error in the scripts I'm looking into.
Will squash this commit with further fixes.
jsuereth added a commit that referenced this issue Aug 21, 2013
@jsuereth
Adding test for bug #19
63232b0
@godenji
Copy link

godenji commented Aug 24, 2013

@jsuereth thanks, the exportJars := true workaround does the trick for including dependent jars, but unfortunately am unable to run the application, "Not a valid Play application"

Might be an issue with Play 2.2, or perhaps my sample project, I'll dig around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsuereth @godenji @huntc