ZIP file names do not extract correctly if ZIP is created on Windows and unzipped on Linux

[doswell]

When a ZIP is created on a Windows platform which passes in file names created from File.getPath, the directory separators used are Windows backslash. The ZIP entry then creates the filename with these backslashes. Unzipping on a Linux based system unzips these files with the filename including the directory name, ie;
share\doc\api\views\html\commands\index$.html
Is the filename.

Similar to IO.scala in sbt, the file names need to be normalized such that if the separatorChar is '' then they need to be replaced with '/'

[jsuereth]

Good catch. Perhaps you should also open a ticket on sbt/sbt about the sbt.IO issue as well....

[doswell]

It looks ok on sbt.IO, came across it from Play Framework packaging, is the intent to keep zipping separate from sbt.IO ZIP handling? there is a sbt.IO.zip method as well.

[jsuereth]

No, our zipping is a bit of a historical accident how it came to be the way it is.

1. sbt.IO zip is fine for simple zip files. However, it doesn't, by default, fill in the Info-Zip permissions
2. We had commons-compress in there at one point which DID fill in the Info-Zip permissions. This only worked for permisisons on Linux, not Mac.
3. We added "useNativeZip" feature so that you could just use native zip Process forks and get all the Info-ZIp and other magic bits you need for MacOSX users. Never cleaned up after this.

I'd like to try to add commons-compress with Info-Zip back in, as it's slightly better than sbt.IO. However, if the default mappings we pass to the zip-creator are bombing, then that needs to be fixed. Thanks for the report. Pull requests welcome, I'll add this to my TODOs before the next release.

[doswell]

Ok, yeah saw a lot of similar zip handling out in sbt.IO - was rather confused trying to track this one down. As soem of the packaging for the jar used sbt.IO but the distro zip used sbt-native-packager. Might just be how the tasks are being setup in play framework.
PR #56 sent

[jsuereth]

Cool, pr was accepted, so closing.