Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application.ini doesn't get replacements such as ${{app_name}} #599

Closed
knshiro opened this issue Jun 11, 2015 · 1 comment
Closed

application.ini doesn't get replacements such as ${{app_name}} #599

knshiro opened this issue Jun 11, 2015 · 1 comment
Labels
bug documentation Documentation should be extended or updated

Comments

@knshiro
Copy link

knshiro commented Jun 11, 2015

Unlike specified in these pages,
http://www.scala-sbt.org/sbt-native-packager/archetypes/java_server/customize
https://github.com/sbt/sbt-native-packager/blob/master/src/sphinx/topics/play.rst
application.ini doesn't get anything replaced (with and without play)
To try just create a basic project with what is suggested in https://github.com/sbt/sbt-native-packager/blob/master/src/sphinx/topics/play.rst

@muuki88
Copy link
Contributor

muuki88 commented Jun 11, 2015

Hi @knshiro . Yeah, that's true and a miss documentation. We will remove this from the docs and see if we should add this. We recommend using the build.sbt approach, e.g.

javaOptions in Universal ++= Seq {
 "-Dhttp.port=8080",
 "-Dapp.user=user",
 s"-D.app.version=${version.value}"
}

This approach is a lot more flexible as you no longer depend on magic string-replacements, but use your variables directly as they are.

@muuki88 muuki88 added documentation Documentation should be extended or updated bug labels Jun 11, 2015
muuki88 added a commit that referenced this issue Jun 15, 2015
FIX #599 #598 Extended docs for application customization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Documentation should be extended or updated
Projects
None yet
Development

No branches or pull requests

2 participants