Fix deprecation warnings in windows WixHelper

[muuki88]

Referring to scala/scala-dist#158 the WixHelper has deprecation warnings since more than two years. We should either fix this or remove the deprecated annotation.

cc: @metasim @nazoking @bjuric

[metasim]

IMO, the WiX support overall could be considered deprecated in favor of JDKPackager (which allows you to use WiX if you want).

[metasim]

@muuki88 I added the deprecation description to remove another warning asking that deprecations have descriptions and dates. I think I guessed at the reason for the deprecation, and never asked @jsuereth. My suggestion, since the plugin is obviously working for some people, is to just remove the deprecation warning, converting it to an inline "TODO".

[SethTisue]

yes please

[muuki88]

@SethTisue happy to merge a pull request 😊

[SethTisue]

happy to merge a pull request

a PR that does "remove the deprecation warning, converting it to an inline "TODO""? I can do that

[SethTisue]

PR: #909

[muuki88]

Will release 1.1.5 and a 1.2.0 Milestone today.