Windows: error CNDL0014 $number is not a legal identifier

[eed3si9n]

steps

clone sbt/sbt-launcher-package

> windows:packageBin

problem

[info] C:\xxx\sbt-launcher-package\target\windows\sbt-launcher-packaging.wix(4378) : error CNDL0014 : The ComponentRef/@Id attribute's value, '48dd0744422128446aee9ac31aa356ee203cc9f4_jars_ivy_jar_sha1190649008', is not a legal identifier.  Identifiers may contain ASCII characters A-Z,
a-z, digits, underscores (_), or periods (.).  Every identifier must begin with either a letter or an underscore.

expectations

No error.

notes

cleanStringForId might have to prefix with underscore when the ID starts with a number.

sbt-native-packager/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala

Lines 259 to 260 in 56e2fc6

	def cleanStringForId(n: String) =
	n.replaceAll("[^0-9a-zA-Z_]", "_").takeRight(60) + (math.abs(n.hashCode).toString + "xxxxxxxxx").substring(0, 9)

[muuki88]

Hi @eed3si9n

Thanks for your bug report.

Do you have a test case where I can reproduce this? ATM I'm testing against the
appveyor test system, so I would open a PR with this test case and then I can fix it.

cheers,
Muki

[eed3si9n]

Clone https://github.com/sbt/sbt-launcher-package/tree/v0.13.14, and run

$ sbt windows:publish