Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix packageZipTarball defaults for UniversalDocs and UniversalSource #1018

Closed
wants to merge 2 commits into from
Closed

fix packageZipTarball defaults for UniversalDocs and UniversalSource #1018

wants to merge 2 commits into from

Conversation

timcharper
Copy link
Contributor

@timcharper timcharper commented Aug 24, 2017 •
edited
Loading

The implementation clearly fell short of the intention.

fixes #1019

@timcharper
Copy link
Contributor Author

Failures do not appear to be related to my patch

muuki88
muuki88 requested changes Aug 26, 2017
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your pull request.

Code LGTM. A regression test for this would be nice :)

@muuki88
Copy link
Contributor

muuki88 commented Aug 26, 2017

I updated the branch, hopefully fixing the travis-ci errors.

@timcharper
Copy link
Contributor Author

@muuki88 can you narrow the search space for me on where to put such a test? :) Give me a few clues? I see the sbt scripting automation but none of the tests seem to run on my laptop. (I have a debian machine I can use... just not available at the moment)

@muuki88 muuki88 added the universal Zip, tar.gz, tgz and bash issues label Aug 30, 2017
@muuki88
Copy link
Contributor

muuki88 commented Aug 30, 2017

Ah! My bad @timcharper 😀

The univeral/test-zips test should be sufficient if you just add the universalDoc:packageBin, etc. tasks.

@muuki88
Copy link
Contributor

muuki88 commented Sep 7, 2017

hi @timcharper :)
Do you need any help?

@muuki88
Copy link
Contributor

muuki88 commented Sep 21, 2017

I'll be on vacation un 20.10. Thanks for your understanding if this can't be merged until then

muuki88 pushed a commit that referenced this pull request Jan 1, 2018
@timcharper @muuki88
fix packageZipTarball defaults for UniversalDocs and UniversalSource
2b5547d 
Resurects #1018
@muuki88 muuki88 mentioned this pull request Jan 1, 2018
Merged
@muuki88 muuki88 closed this Jan 1, 2018
@muuki88
Copy link
Contributor

muuki88 commented Jan 1, 2018

Thanks for your work here @timcharper
I opened a new pull request to get this fix into master :)

muuki88 pushed a commit that referenced this pull request Jan 1, 2018
@timcharper @muuki88
fix packageZipTarball defaults for UniversalDocs and UniversalSource
59dca50 
Resurects #1018
muuki88 added a commit that referenced this pull request Jan 8, 2018
@muuki88
fix packageZipTarball defaults for UniversalDocs and UniversalSource (#…
cea4517 
…1086)

* fix packageZipTarball defaults for UniversalDocs and UniversalSource

Resurects #1018

* Add mappings to universalSrc/universalDocs and create working directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 requested changes

Assignees
No one assigned
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

packageZipTarball defaults not provided for UniversalDocs and UniversalSource, as it is with Universal
2 participants
@timcharper @muuki88