Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to move docker-client dependency back to the provided scope #1196

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Attempt to move docker-client dependency back to the provided scope #1196

merged 4 commits into from
Jan 25, 2019

Conversation

gpgekko
Copy link
Contributor

@gpgekko gpgekko commented Jan 25, 2019

Attempt to fix #1194 by trying to copy the method used in #1097.

@muuki88
Copy link
Contributor

muuki88 commented Jan 25, 2019

Run $ sbt scalafmtAll and then commit the formatted files :)

@gpgekko
Copy link
Contributor Author

gpgekko commented Jan 25, 2019

Ah, thanks. That wasn't mentioned in the contributing guide.

@muuki88
Copy link
Contributor

muuki88 commented Jan 25, 2019

Ah, thanks. That wasn't mentioned in the contributing guide.

Oh! I will add that. Thanks for pointing out 😃

muuki88
muuki88 approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️

@muuki88 muuki88 merged commit a2baeb2 into sbt:master Jan 25, 2019
@gpgekko gpgekko deleted the docker-client-provided branch January 28, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put Spotify docker-client back in provided scope
2 participants
@gpgekko @muuki88