JlinkPlugin: restrict linking to platform modules #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is due to this: #1246 |
muuki88
approved these changes
Jul 12, 2019
src/main/scala/com/typesafe/sbt/packager/archetypes/jlink/JlinkPlugin.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1247 .
This is a short-term solution to #1247, as outlined in #1247 (comment) (point 1). The long-term solution (
JlinkPluginrefactoring/rewrite - #1247 (comment)) will be a separate issue.jlink--module-pathseparator issue.jlinkModulePathto default to an empty list - we don't need it for platform modules.Detecting platform modules has special cases - for historical reasons some Jakarta modules use
java.*names, so we have to exclude them on a case by case basis. I'm not positive I got all of these - some seem to rely on automatic modules for their dependencies, and those are not properly supported byjlink/jdepsAFAICT... All in all, Jakarta's JPMS transition is a mess.