Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added command line JAVA_OPTS support for AshScriptPlugin #1255

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Added command line JAVA_OPTS support for AshScriptPlugin #1255

merged 1 commit into from
Aug 29, 2019

Conversation

farico
Copy link
Contributor

@farico farico commented Aug 21, 2019

Added support for passing -Dconfig.resource and other JAVA_OPTS in default ash-template. See #1254

@lightbend-cla-validator
Copy link

Hi @farico,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@farico
Copy link
Contributor Author

farico commented Aug 21, 2019

I did sign the CLA

@muuki88 muuki88 added the universal Zip, tar.gz, tgz and bash issues label Aug 22, 2019
@muuki88
Copy link
Contributor

muuki88 commented Aug 22, 2019

Thanks for the fast PR ❤️

Code LGTM. Can you add an sbt test for this features as well. You can find the existing tests under src/sbt-test/ash

@farico farico force-pushed the ashPluginJavaOptsCliSupport branch from a6abd15 to b47983f Compare August 24, 2019 11:45
@farico
Copy link
Contributor Author

farico commented Aug 24, 2019

I have added a test. Please let me know what you think about it.

@farico
Copy link
Contributor Author

farico commented Aug 28, 2019

ping

muuki88
muuki88 approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. With my family I have very little time for open source 🙂

Thanks for the test. This looks perfect now. ☺️

@muuki88 muuki88 merged commit 905d425 into sbt:master Aug 29, 2019
@farico farico deleted the ashPluginJavaOptsCliSupport branch August 29, 2019 07:37
@muuki88
Copy link
Contributor

muuki88 commented Aug 30, 2019

Release v1.4.1 is on its way

@gregsymons gregsymons mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farico @lightbend-cla-validator @muuki88