Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument passing in ash template #1334

Merged
merged 1 commit into from
May 4, 2020
Merged

Fix argument passing in ash template #1334

merged 1 commit into from
May 4, 2020

Conversation

bentucker
Copy link
Contributor

Fixes #1332

@lightbend-cla-validator
Copy link

Hi @bentucker,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

muuki88
muuki88 approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bentucker for fixing this 🤗 👍 and the well done PR.

@muuki88 muuki88 merged commit 0a393ad into sbt:master May 4, 2020
@muuki88
Copy link
Contributor

muuki88 commented May 4, 2020

Released in v1.7.1

@eed3si9n eed3si9n mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AshScriptPlugin with DockerPlugin does not correctly pass arguments
3 participants
@bentucker @lightbend-cla-validator @muuki88