-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #98 java server type includes /etc/default by default #140
Conversation
muuki88
commented
Jan 28, 2014
- Added default configuration location
- Added replacements in /etc/default configuration
- Added tests
- Added default configuration file with examples
- Added /etc/default script to Upstart
* Added default configuration location * Added replacements in /etc/default configuration * Added tests * Added default configuration file with examples * Added /etc/default script to Upstart
And how can I specify command line arguments to my program? You put debian package properties inside package? I think /etc/default/ is basically for storing some parameters such as daemonUser. +# Available replacements
+# ------------------------------------------------
+# ${{author}} debian author
+# ${{descr}} debian package description |
I still have to dig a bit deeper in the startup script. There is an option for commandline parameters. The replacements are just the default ones, available in every maintainerscript. |
# Setting -X directly (-J is stripped) | ||
# -J-X | ||
# -J-Xmx 1024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be -J-Xmx1024
(no space).
Nice work! I only have a minor comment. |
@aparkinson or @jsuereth if you're okay with this, then we merge this into master. |
Looks good to me! |
Fix #98 java server type includes /etc/default by default
And what about |
What I'm currently starting to think about is extending the IMHO we should keep configuration settings out of the start script. However there is a method to add app arguments, which is never called? |
@muuki88 Would having files in a directory effectively override existing config files packaged inside the jars? Our Play! app has an internal safe config file and we use |
Exactly. The standard behavior states The API for this must:
What do you thinkg @aparkinson ? |
Sounds great for me. |
+1 I didn't know about that, sounds like the right way to go |
If will provide a PR for this. |