Wip/rpm server archetype #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added linuxSettings for server archetype - Added pid folder in server archetype - Refactored JavaStartScript class/object - Tested with CentOS 6.5
| @@ -128,7 +128,7 @@ execRunner () { | |||
| } | |||
|
|
|||
| # We Don't use "exec" here for our pids to be accurate. | |||
| "$@" | |||
| exec "$@" | |||
There was a problem hiding this comment.
:) We keep changing our minds here. Exec feels right as this should make the PID files line up.
There was a problem hiding this comment.
Yep, it should. We were all a bit confused (#168) However I'm with @kardapoltsev and we should put it back as this is the way to go.
|
Cool. I like this change, travis CI says it passed. If you're done with this change, feel free to merge. The System V script still looks like it might need something to change the daemonUser (important for security). Otherwise, looks good. |
|
I'll write one more test and run the service as daemon user. |
Adding preinst and postuninstall scripts (wip)
|
Okay. I think we can merge this and improve based on that. Left todo is
|
This was referenced Mar 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #149
This PR is based on PR #174 to minimize merging overhead.
What has be done
exectobash-scriptagain for correct PID handlingMore details
After installing the rpm with
you access the service with
TODO
daemonUseranddaemonGroupare not created. Root is used a fallback by rpmUpstartdoesn't work (just copied the debian configuration, but no luck)