Wip/cleanup for play #18
Conversation
* Add `makeBashScript` key to global Keys. * Update JavaAppbashScript to use `makeBashScript` key. * Move BASH script itself into resources as a template file. * Update Java app archetype to be friendlier * Add new test for non-prefixed `stage` and `dist` tasks * Adding test to ensure autogenerated bash script works.
…t in windows and not WINE.
|
Oh, also, @huntc -> I cut a milestone release of this code @ 0.6.0-milestone-for-ch-1. Ping me if I need to clarify any bits :) |
* Add \ where appropriate * Remove @template_defines@ as it was unused.
| declare -r java_cmd=$(get_java_cmd) | ||
| # TODO - Check whether this is ok in cygwin... | ||
| declare -r lib_dir="${app_home}/../lib" | ||
| declare -r app_classpath="$lib_dir/*" |
There was a problem hiding this comment.
We need to be able to express the classpath as a parameter to the template. The order of things on the classpath is significant to Play as we try to be compatible with the order of things in the classpath during dev mode.
I've defined a taskkey named "playDistLibs" that yields a Seq(File, String). If the product of something like that can be fed to the template then that'd be great.
There was a problem hiding this comment.
hmm, actually enforcing is order may be something more than just play specific. Let me think about a good way to resolve the general case, and I'll add a quick hook for you now.
* Use same classpath ordering as sbt in start scripts * Allow user configuration of additional hooks for the script. Review by @huntc to see if we're any closer to parity with Play.
* Consolidate names to use "script" * Add better descriptions * Update the docs a bit.
|
Cool, I'm going to merge and test again on windows (just in case), then cut a 0.6.0. We can make updates to the java application during the 0.6.x series because it's still experimental. I know we'll need more hooks over time too. |
distandstagein the sbt prompt workReview by @huntc with the following notes/caveats:
make-bash-scriptandmake-bat-scriptreturnOption[File]rather thanFile. This means we could default to None if we had to. Right nowJavaApparchetype would be ok either way. I'm on the fence as to how we should actually do this. You'll have to use the java app archetype settings to get these defaults though, which I think is the right thing for play right now.batfile remains untested until I pass this code off to the windows box. Wanted to get this in font of your eyes, as I'll be on windows the rest of the day.mainClassin play, unless it already does this.Let me know what you think.