-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up name delegation in the plugin. A few rules: #250
Conversation
* Each configuration should have its own `name` and `normalizedName` instance * Debian/Rpm delegate to Linux which delegates to project name. * Universal has its own name, which is used for generating BASH/BAT files * Separate key for the package filename now * Windows has its own name/normalized name which delegates to raw. Fixes #188
Review by @muuki88 cc> @timperrett |
packageSummary in Rpm <<= packageSummary in Linux, | ||
packageDescription in Rpm <<= packageDescription in Linux, | ||
target in Rpm <<= target(_ / "rpm") | ||
target in Rpm <<= target(_ / "rpm"), | ||
name in Rpm <<= name in Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if I specify name in RPM := "xyz"
it will still work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should. It will get normalized, which is something we may want to rethink soon.
Hmmm. I'm thinking about introducing a new Setting Then we can just use |
Excuse me that was a stupid mistake on buttons). |
@muuki88 Yeah, I think that's a far better idea. What we should do perhaps:
Sound reasonable? |
Sure!) |
+1 for |
Conflicts: src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala src/main/scala/com/typesafe/sbt/packager/rpm/RpmPlugin.scala src/sbt-test/debian/test-mapping/test
I merged the current master into this pr. What has to be done here? |
Project.normalizeModuleID only exists in SBT 0.13. Possibly use StringUtilities.normalize instead (it's deprecated, but present in SBT 0.12)? |
What are you referring to? I went through the discussion and will start to implement the |
Conflicts: src/main/scala/com/typesafe/sbt/packager/debian/DebianPlugin.scala
@jsuereth, so this is my use case: #296 What are your thoughts on adding additional keys such as What I don't like about this is that there's already a |
@pcting , once we detangled everything from the |
@muuki88 your changes LGTM!! |
So, this should be it. I'm currently working on a documentation, which will also be the starting point for the next configuration refactorings. @jsuereth , @aparkinson , @kardapoltsev I added a lot of tests, but nothing guaranteed . |
One last thing @jsuereth . Is this binary compatible? Can it be merged in the |
@muuki88 Yeah, as long as it's just new keys and modifying existing |
Clean up name delegation in the plugin. A few rules:
Adding docs for name-delegation in #250
name
andnormalizedName
instanceFixes #188