Fix java 8 version check #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -284,7 +284,7 @@ loadConfigFile() { | |||
| # Now check to see if it's a good enough version | |||
| # TODO - Check to see if we have a configured default java version, otherwise use 1.6 | |||
| java_version_check() { | |||
| declare -r java_version=$("$java_cmd" -version 2>&1 | awk -F '"' '/version/ {print $2}') | |||
| readonly java_version=$("$java_cmd" -version 2>&1 | awk -F '"' '/version/ {print $2}') | |||
There was a problem hiding this comment.
readonly declares java_version globally and declare -r doesn't?
There was a problem hiding this comment.
That's what I found while testing with the mentioned bash version. I'm by no means a bash expert though so maybe there's a better way to do this? I stumbled upon the readonly trick here: http://stackoverflow.com/a/12158728/547212
There was a problem hiding this comment.
This is very interesting as this seems to depend on the bash version. I'll need to take a closer look at this.
Thanks for the research!
|
this pr is not lost! I hope to get to it as soon as possible. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java 8 version check in the bash-template does not currently work. There are two issues:
no_java_version_checkinstead ofno_version_check$java_versionis a global variable but that is not currently exported byjava_version_check, at least when running under bash 3.2.51(1)-release on OS X Mavericks