Fixed user deletion issue in rpm postuninstall scriptlet. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p during rpm upgrade.
|
Hi @ei82, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
| @@ -1,12 +1,16 @@ | |||
| # Removing system user/group : ${{daemon_user}} and ${{daemon_group}} | |||
| echo "Try deleting system user and group [${{daemon_user}}:${{daemon_group}}]" | |||
| if getent passwd | grep -q "^${{daemon_user}}:"; | |||
| if [[ $1 == 0 ]] | |||
There was a problem hiding this comment.
Thanks for figuring that out! Can you place a comment there and maybe with the link?
Something like $1 == 1 is upgrade and $1 == 0 is uninstall
|
LGTM. Thanks for linking the fedora syntax page. One little comment and the CLA that this should be good to merge |
|
Done. |
muuki88
added a commit
that referenced
this pull request
Jun 14, 2014
Fixed user deletion issue in rpm postuninstall scriptlet.
|
Thanks again for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default rpm postuninstall scriptlet unconditionally deletes user / group.
This is a problem when someone tries to upgrade a package in one step (using rpm -U package-name).
Currently this ends up with upgraded package artifacts and removed package user.
The fix adds a check which tests number of packages which will be left in the system after the action completes:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Syntax