FIX #324 adding empty dirs to deb package #325
Conversation
| paths map { | ||
| case (path, name) if path.isDirectory => | ||
| val permMapper = new PermMapper(-1, -1, perms.user, perms.group, null, perms.permissions, -1, null) | ||
| new DataProducerDirectory(target / name, null, Array("**"), Array(permMapper)) | ||
| val dirName = if (name.startsWith("/")) name.drop(1) else name | ||
| new DataProducerDirectory(target, Array(dirName), null, Array(permMapper)) |
There was a problem hiding this comment.
This doesn't look wrong, but doesn't look correct either :/ So we have
pDir = target
pIncludes = Array(dirName)
pExclues = null // nothing to exclude
pMapper = Array(permMapper)
This means that if you add a directory producer with an empty directory and exclude all it's contents (the way before), the empty directory doesn't get created? Sounds for me more like a bug in jdeb. @tcurdt @ebourg may know more about this?
There was a problem hiding this comment.
I've dug into jdeb sources before I could get it works)
There was a problem hiding this comment.
Thought so :( Well, as this is a bit mysterious after all, we should really add tests for this
|
Also a test would be nice to check if this really works. One with an empty directory and one with a none empty directory. |
It's very strange since this tests were successfull on my machine.. :( |
|
Any ideas about how can I debug this case? |
|
Hm. That's rather strange. I'll try to build this on my computer and report if I got any failure. |
|
So... It works on my Gentoo and latest Ubuntu and doesn't work on stable Debian. Very interesting issue. |
|
Solution is simple) I've tried to add empty dir to mappings, but I couldn't add empty dir to git, hence on travis this empty dir really doesn't exists and not added to mappings. |
|
Well... that makes sense :D Didn't saw that in the code, damn :/ |
FIX #324 adding empty dirs to deb package
|
Merged into |
No description provided.