Describe server loading options in server docs #379
Conversation
|
You are awesome. Can you add your system in the table above as well? |
|
@muuki88 Can you clarify? Do you mean something like this: | Ubuntu | Upstart | X | I didn't explicitly test Fedora, and I need to add a caveat about CentOS and upstart. By default, requiretty is enabled which makes it impossible to sudo in the upstart config. But disabling requiretty makes it work. I can add that info and whatever else you're asking for. No problem. |
|
Exactly.If you have time testing fedora, this would be awesome, but it's fine if you just add your system you ran on. Looking forward to some bashScriptExtraDefines docs :-) |
|
| As you read earlier the ```bashScriptExtraDefines``` sequence allows you to add new lines to the default bash script used to start the application. | ||
| This is useful when you need a setting which isn't mean for the command-line parameter list passed to the java process. The lines added to | ||
| ```bashScriptExtraDefines``` are placed near the end of the script and have access to a number of utility bash functions (e.g. ``addJava``, | ||
| ``addApp``, ``addResidual``, ``addDebugger``). You can add lines to this script as we did for the Typesage config file above. For more complex |
There was a problem hiding this comment.
Typo: typesafe instead of typesa_g_e
|
Wow! Thanks a lot for detailed documentation. The ability to override particular snippets inside the shipped bashscripts is pretty new, so was it difficult to find out ( despite the fact that there were no doc ) |
| ``addApp``, ``addResidual``, ``addDebugger``). You can add lines to this script as we did for the Typesage config file above. For more complex | ||
| scripts you can also inject a seperate file managed in your source tree or resource directory: :: | ||
|
|
||
| bashScriptExtraDefines := Source.fromInputStream(this.getClass.getResourceAsStream("/setup-env")).getLines.toSeq |
There was a problem hiding this comment.
I think it's better to recommend appending to this setting, in case some other plugin wants to add its own (hopefully compatible) lines.
Also, it seems like it might be more consistent to make use of the same IO library throughout the examples, and sbt.IO is used in the next example.
An alternative (untested) could be:
bashScriptExtraDefines ++= IO.readLinesURL(this.getClass.getResource("/setup-env"))There was a problem hiding this comment.
I agree and will make the change. It will also tighten up the
documentation.
On Fri, Oct 17, 2014 at 6:31 AM, Gary Coady notifications@github.com
wrote:
In src/sphinx/GettingStartedApplications/AddingConfiguration.rst:
@@ -130,5 +130,20 @@ One means of doing this is hooking the
batScriptExtraDefineskey. This alloNow, the windows version will also load the configuration from the
conf/directory of the package.+More Complex Scripts
+--------------------
+
+As you read earlier thebashScriptExtraDefinessequence allows you to add new lines to the default bash script used to start the application.
+This is useful when you need a setting which isn't mean for the command-line parameter list passed to the java process. The lines added to
+bashScriptExtraDefinesare placed near the end of the script and have access to a number of utility bash functions (e.g.addJava,
+addApp,addResidual,addDebugger). You can add lines to this script as we did for the Typesage config file above. For more complex
+scripts you can also inject a seperate file managed in your source tree or resource directory: ::
+
- bashScriptExtraDefines := Source.fromInputStream(this.getClass.getResourceAsStream("/setup-env")).getLines.toSeq
I think it's better to recommend appending to this setting, in case some
other plugin wants to add its own (hopefully compatible) lines.Also, it seems like it might be more consistent to make use of the same IO
library throughout the examples, and sbt.IO is used in the next example.An alternative (untested) could be:
bashScriptExtraDefines ++= IO.readLinesURL(this.getClass.getResource("/setup-env"))
—
Reply to this email directly or view it on GitHub
https://github.com/sbt/sbt-native-packager/pull/379/files#r19010987.
|
I squashed the commits and made the following changes:
|
| @@ -2,21 +2,20 @@ SBT - Native Packager Plugin | |||
| ############################ | |||
|
|
|||
| This is the documentation for the sbt-native-packager plugin. This plugin aims | |||
| to allow native packages to be created for all major operating systems, including: | |||
| to allow easy generation of native packages for all major operating systems, including: | |||
|
Thanks a lot for your effort. I'll port this to 0.7.x and 0.8.x ASAP. |
Describe server loading options in server docs
|
merged into |
Wanted to document options for overriding the default server loader as per #376. I've already signed the typesafe CLA, but maybe not for sbt-native-packager.