Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix too long classpaths in script(bat/bash). #397

Merged
merged 2 commits into from
Nov 11, 2014

Conversation

nazoking
Copy link
Contributor

the maximum length of the string that you can use at the command prompt is 8191 characters. http://support.microsoft.com/kb/830473/en-us

Create manifest.jar it contains Class-Path manifest.
java classpath option need only a manifest.jar.

java -Xjvmopt1 -Xjvmopt2 -cp org.name-version-artifactClassifier.jar:scala-liblary.jar:aaaaaa.jar:bbbbbb:jar:cccc.jar:......:xxxxxx.jar mainClass arg1 arg2

java -Xjvmopt1 -Xjvmopt2 -cp org.name-version-artifactClassifier-manifest.jar mainClass arg1 arg2

This patch affects both the batch script and bash script.

fix #72

Create manifest.jar it contains Class-Path manifest.
java classpath option need only a manifest.jar.
@muuki88
Copy link
Contributor

muuki88 commented Oct 28, 2014

Code looks good. However I would like to extract this function into a separate AutoPlugin.
We will have some of the jar-packaging plugins soon. Like assembly, fat-jar, classpath-jar.

Ideally the scriptClasspath settings would be the only setting this plugin sets. It should require the UniversalPlugin, which adds the scriptClasspath. You can create a new package for this in com/typesafe/sbt/packager/jar

@muuki88
Copy link
Contributor

muuki88 commented Nov 10, 2014

@nazoking you need more guidance here?

@nazoking
Copy link
Contributor Author

Does this commit meets your request?

@muuki88
Copy link
Contributor

muuki88 commented Nov 11, 2014

This looks awesome! I will take care of a linux test. If you have time you can provide some docs in another commit.

muuki88 added a commit that referenced this pull request Nov 11, 2014
fix too long classpaths in script(bat/bash).
@muuki88 muuki88 merged commit 268d010 into sbt:master Nov 11, 2014
@jroper
Copy link
Member

jroper commented Nov 13, 2014

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start command too long on some platforms with big classpaths
3 participants